PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/apache/jsieve/util/HaltTraversalException.java

ViolationLine
It is a good practice to call super() in a constructor30 - 31

org/apache/jsieve/util/NodeHandler.java

ViolationLine
Avoid modifiers which are implied by the context48
Avoid modifiers which are implied by the context54
Avoid modifiers which are implied by the context61
Avoid modifiers which are implied by the context68
Avoid modifiers which are implied by the context75
Avoid modifiers which are implied by the context82
Avoid modifiers which are implied by the context89
Avoid modifiers which are implied by the context96
Avoid modifiers which are implied by the context103
Avoid modifiers which are implied by the context110
Avoid modifiers which are implied by the context117
Avoid modifiers which are implied by the context124
Avoid modifiers which are implied by the context131
Avoid modifiers which are implied by the context138
Avoid modifiers which are implied by the context145
Avoid modifiers which are implied by the context152
Avoid modifiers which are implied by the context159
Avoid modifiers which are implied by the context166
Avoid modifiers which are implied by the context173
Avoid modifiers which are implied by the context180
Avoid modifiers which are implied by the context187
Avoid modifiers which are implied by the context194
Avoid modifiers which are implied by the context201
Avoid modifiers which are implied by the context208

org/apache/jsieve/util/NodeToSieveAdapter.java

ViolationLine
Avoid using final local variables, turn them into fields99
Avoid using final local variables, turn them into fields141
Avoid using final local variables, turn them into fields145
Avoid using final local variables, turn them into fields150
Avoid using final local variables, turn them into fields154
Avoid using final local variables, turn them into fields155
Avoid using final local variables, turn them into fields158
Avoid using final local variables, turn them into fields169
Avoid using final local variables, turn them into fields178

org/apache/jsieve/util/NodeTraverser.java

ViolationLine
Avoid using final local variables, turn them into fields51

org/apache/jsieve/util/OutputUtils.java

ViolationLine
Avoid using final local variables, turn them into fields71
Avoid using final local variables, turn them into fields72
Avoid using final local variables, turn them into fields73
Avoid using final local variables, turn them into fields74
Avoid using final local variables, turn them into fields85
Avoid using final local variables, turn them into fields86
Avoid using final local variables, turn them into fields87

org/apache/jsieve/util/SieveHandler.java

ViolationLine
Avoid modifiers which are implied by the context40
Avoid modifiers which are implied by the context47
Avoid modifiers which are implied by the context54
Avoid modifiers which are implied by the context61
Avoid modifiers which are implied by the context68
Avoid modifiers which are implied by the context75
Avoid modifiers which are implied by the context83
Avoid modifiers which are implied by the context91
Avoid modifiers which are implied by the context99
Avoid modifiers which are implied by the context106
Avoid modifiers which are implied by the context116
Avoid modifiers which are implied by the context124
Avoid modifiers which are implied by the context131
Avoid modifiers which are implied by the context138
Avoid modifiers which are implied by the context146
Avoid modifiers which are implied by the context153
Avoid modifiers which are implied by the context160
Avoid modifiers which are implied by the context168
Avoid modifiers which are implied by the context176
Avoid modifiers which are implied by the context182 - 259

org/apache/jsieve/util/SieveToXml.java

ViolationLine
Avoid modifiers which are implied by the context85
Avoid modifiers which are implied by the context92
Avoid modifiers which are implied by the context102
Avoid modifiers which are implied by the context108
Avoid modifiers which are implied by the context121
Avoid using final local variables, turn them into fields158
Avoid using final local variables, turn them into fields331 - 332

org/apache/jsieve/util/ToSieveHandlerFactory.java

ViolationLine
It is a good practice to call super() in a constructor62 - 68

org/apache/jsieve/util/XmlOut.java

ViolationLine
Use explicit scoping instead of the default package private level405
Use explicit scoping instead of the default package private level406
Use explicit scoping instead of the default package private level407
Avoid using final local variables, turn them into fields536
Avoid using final local variables, turn them into fields558
Avoid using final local variables, turn them into fields578
Found 'DU'-anomaly for variable 'elementName' (lines '578'-'590').578 - 590
These nested if statements could be combined604 - 606
Avoid using final local variables, turn them into fields616
Found 'DD'-anomaly for variable 'result' (lines '622'-'628').622 - 628
Found 'DD'-anomaly for variable 'result' (lines '622'-'633').622 - 633
Avoid using final local variables, turn them into fields623
Avoid using final local variables, turn them into fields642
Avoid using final local variables, turn them into fields643
Avoid using final local variables, turn them into fields648
Avoid using final local variables, turn them into fields649
Avoid using final local variables, turn them into fields654
Avoid using final local variables, turn them into fields659
Avoid using final local variables, turn them into fields669

org/apache/jsieve/util/check/ScriptCheckMailAdapter.java

ViolationLine
Avoid using final local variables, turn them into fields108
Avoid using final local variables, turn them into fields120
Avoid using final local variables, turn them into fields132
Avoid using final local variables, turn them into fields133
Found 'DD'-anomaly for variable 'result' (lines '156'-'161').156 - 161
Found 'DU'-anomaly for variable 'result' (lines '156'-'168').156 - 168
Found 'DU'-anomaly for variable 'result' (lines '161'-'168').161 - 168
Found 'DD'-anomaly for variable 'results' (lines '179'-'182').179 - 182
Found 'DU'-anomaly for variable 'results' (lines '182'-'196').182 - 196
Avoid using final local variables, turn them into fields183
Avoid using final local variables, turn them into fields185
Avoid using final local variables, turn them into fields186
Found 'DD'-anomaly for variable 'result' (lines '217'-'219').217 - 219
Found 'DD'-anomaly for variable 'result' (lines '231'-'234').231 - 234
Found 'DU'-anomaly for variable 'result' (lines '234'-'240').234 - 240
Found 'DD'-anomaly for variable 'result' (lines '250'-'253').250 - 253
Found 'DU'-anomaly for variable 'result' (lines '253'-'259').253 - 259
Found 'DD'-anomaly for variable 'result' (lines '268'-'271').268 - 271
Found 'DU'-anomaly for variable 'result' (lines '271'-'279').271 - 279
Avoid using final local variables, turn them into fields299
Avoid using final local variables, turn them into fields302
Avoid using final local variables, turn them into fields303
Avoid using final local variables, turn them into fields309

org/apache/jsieve/util/check/ScriptChecker.java

ViolationLine
Avoid using final local variables, turn them into fields66
Avoid using final local variables, turn them into fields67
Avoid using final local variables, turn them into fields68
Avoid using final local variables, turn them into fields89
Found 'DD'-anomaly for variable 'results' (lines '90'-'93').90 - 93
Found 'DD'-anomaly for variable 'results' (lines '93'-'96').93 - 96
Found 'DD'-anomaly for variable 'result' (lines '160'-'164').160 - 164
Found 'DD'-anomaly for variable 'result' (lines '178'-'182').178 - 182
Found 'DD'-anomaly for variable 'result' (lines '196'-'200').196 - 200
Found 'DD'-anomaly for variable 'result' (lines '211'-'214').211 - 214