PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/apache/james/jdkim/api/BodyHasher.java

Violation Line
Avoid modifiers which are implied by the context 26
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 30

org/apache/james/jdkim/api/Headers.java

Violation Line
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 41

org/apache/james/jdkim/api/PublicKeyRecord.java

Violation Line
Avoid modifiers which are implied by the context 28
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 39
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 54

org/apache/james/jdkim/api/PublicKeyRecordRetriever.java

Violation Line
Avoid modifiers which are implied by the context 42 - 44

org/apache/james/jdkim/api/SignatureRecord.java

Violation Line
Avoid modifiers which are implied by the context 30
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 32
Avoid modifiers which are implied by the context 34
Avoid modifiers which are implied by the context 36
Avoid modifiers which are implied by the context 38
Avoid modifiers which are implied by the context 40
Avoid modifiers which are implied by the context 42
Avoid modifiers which are implied by the context 44
Avoid modifiers which are implied by the context 46
Avoid modifiers which are implied by the context 48
Avoid modifiers which are implied by the context 50
Avoid modifiers which are implied by the context 52
Avoid modifiers which are implied by the context 54
Avoid modifiers which are implied by the context 56
Avoid modifiers which are implied by the context 58
Avoid modifiers which are implied by the context 60
Avoid modifiers which are implied by the context 62
Avoid modifiers which are implied by the context 64
Avoid modifiers which are implied by the context 66
Avoid modifiers which are implied by the context 68

org/apache/james/jdkim/canon/CompoundOutputStream.java

Violation Line
Use explicit scoping instead of the default package private level 29
It is a good practice to call super() in a constructor 31 - 33

org/apache/james/jdkim/canon/RelaxedBodyCanonicalizer.java

Violation Line
Found 'DU'-anomaly for variable 'start' (lines '40'-'68'). 40 - 68
Found 'DU'-anomaly for variable 'start' (lines '49'-'68'). 49 - 68
Avoid empty if statements 54 - 57

org/apache/james/jdkim/canon/SimpleBodyCanonicalizer.java

Violation Line
Found 'DD'-anomaly for variable 'newCountCRLF' (lines '60'-'68'). 60 - 68
Found 'DD'-anomaly for variable 'newLastWasCR' (lines '61'-'63'). 61 - 63
Found 'DD'-anomaly for variable 'newCountCRLF' (lines '68'-'68'). 68

org/apache/james/jdkim/DKIMCommon.java

Violation Line
Found 'DD'-anomaly for variable 'headerValue' (lines '48'-'49'). 48 - 49
Found 'DU'-anomaly for variable 'processedHeader' (lines '79'-'103'). 79 - 103
Avoid assignments in operands 109
Found 'DU'-anomaly for variable 'read' (lines '109'-'114'). 109 - 114

org/apache/james/jdkim/DKIMSigner.java

Violation Line
It is a good practice to call super() in a constructor 50 - 53
Found 'DU'-anomaly for variable 'message' (lines '68'-'86'). 68 - 86

org/apache/james/jdkim/DKIMVerifier.java

Violation Line
It is a good practice to call super() in a constructor 58 - 61
It is a good practice to call super() in a constructor 63 - 65
Found 'DD'-anomaly for variable 'lastError' (lines '87'-'89'). 87 - 89
Found 'DU'-anomaly for variable 'lastError' (lines '87'-'108'). 87 - 108
These nested if statements could be combined 136 - 140
Found 'DD'-anomaly for variable 'lastTempFailure' (lines '158'-'175'). 158 - 175
Found 'DU'-anomaly for variable 'lastTempFailure' (lines '158'-'192'). 158 - 192
Found 'DD'-anomaly for variable 'lastPermFailure' (lines '159'-'177'). 159 - 177
Found 'DU'-anomaly for variable 'lastPermFailure' (lines '159'-'192'). 159 - 192
Found 'DD'-anomaly for variable 'lastTempFailure' (lines '175'-'175'). 175
Found 'DU'-anomaly for variable 'lastTempFailure' (lines '175'-'192'). 175 - 192
Found 'DD'-anomaly for variable 'lastPermFailure' (lines '177'-'177'). 177
Found 'DU'-anomaly for variable 'lastPermFailure' (lines '177'-'192'). 177 - 192
Found 'DU'-anomaly for variable 'bodyHashJobs' (lines '244'-'353'). 244 - 353
Found 'DU'-anomaly for variable 'outputStreams' (lines '245'-'353'). 245 - 353
Found 'DU'-anomaly for variable 'signatureExceptions' (lines '246'-'353'). 246 - 353
A method should have only one exit point, and that should be the last statement in the method 357 - 358

org/apache/james/jdkim/impl/BodyHasherImpl.java

Violation Line
Use explicit scoping instead of the default package private level 77 - 87
Found 'DD'-anomaly for variable 'out' (lines '79'-'81'). 79 - 81
Found 'DD'-anomaly for variable 'out' (lines '79'-'83'). 79 - 83
Found 'DD'-anomaly for variable 'out' (lines '79'-'85'). 79 - 85

org/apache/james/jdkim/impl/DNSPublicKeyRecordRetriever.java

Violation Line
Found 'DU'-anomaly for variable 'rr' (lines '63'-'76'). 63 - 76
A method should have only one exit point, and that should be the last statement in the method 71
Found 'DU'-anomaly for variable 'records' (lines '88'-'122'). 88 - 122
A method should have only one exit point, and that should be the last statement in the method 115
Assigning an Object to null is a code smell. Consider refactoring. 119

org/apache/james/jdkim/impl/Message.java

Violation Line
Avoid using final local variables, turn them into fields 136
Avoid using final local variables, turn them into fields 137
Avoid using final local variables, turn them into fields 138
Avoid assignments in operands 165
Found 'DU'-anomaly for variable 'read' (lines '165'-'172'). 165 - 172
Avoid empty catch blocks 168 - 169

org/apache/james/jdkim/tagvalue/PublicKeyRecordImpl.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 95
A method should have only one exit point, and that should be the last statement in the method 112
Found 'DU'-anomaly for variable 'pStar' (lines '130'-'156'). 130 - 156
These nested if statements could be combined 132 - 134
A method should have only one exit point, and that should be the last statement in the method 141
A method should have only one exit point, and that should be the last statement in the method 150

org/apache/james/jdkim/tagvalue/SignatureRecordImpl.java

Violation Line
Found 'DD'-anomaly for variable 'measure' (lines '78'-'83'). 78 - 83
Found 'DU'-anomaly for variable 'measure' (lines '78'-'112'). 78 - 112
Found 'DD'-anomaly for variable 'measure' (lines '83'-'86'). 83 - 86
Found 'DD'-anomaly for variable 'measure' (lines '86'-'89'). 86 - 89
Found 'DD'-anomaly for variable 'measure' (lines '89'-'92'). 89 - 92
Found 'DD'-anomaly for variable 'measure' (lines '92'-'95'). 92 - 95
A method should have only one exit point, and that should be the last statement in the method 125
Found 'DU'-anomaly for variable 'sb' (lines '145'-'205'). 145 - 205
Found 'DU'-anomaly for variable 'state' (lines '149'-'205'). 149 - 205
Found 'DU'-anomaly for variable 'start' (lines '150'-'205'). 150 - 205
Found 'DD'-anomaly for variable 'start' (lines '150'-'191'). 150 - 191
Found 'DU'-anomaly for variable 'd' (lines '151'-'205'). 151 - 205
Found 'DD'-anomaly for variable 'd' (lines '151'-'186'). 151 - 186
Found 'DD'-anomaly for variable 'd' (lines '151'-'188'). 151 - 188
Found 'DU'-anomaly for variable 'lastWasNL' (lines '152'-'205'). 152 - 205
Found 'DD'-anomaly for variable 'lastWasNL' (lines '158'-'167'). 158 - 167
Found 'DU'-anomaly for variable 'lastWasNL' (lines '158'-'205'). 158 - 205
Found 'DU'-anomaly for variable 'lastWasNL' (lines '167'-'205'). 167 - 205
Found 'DU'-anomaly for variable 'start' (lines '169'-'205'). 169 - 205
Found 'DU'-anomaly for variable 'state' (lines '185'-'205'). 185 - 205
Found 'DU'-anomaly for variable 'd' (lines '186'-'205'). 186 - 205
Found 'DD'-anomaly for variable 'd' (lines '186'-'186'). 186
Found 'DD'-anomaly for variable 'd' (lines '186'-'188'). 186 - 188
Found 'DU'-anomaly for variable 'state' (lines '190'-'205'). 190 - 205
Found 'DU'-anomaly for variable 'start' (lines '191'-'205'). 191 - 205
Found 'DD'-anomaly for variable 'start' (lines '191'-'191'). 191
A method should have only one exit point, and that should be the last statement in the method 242
A method should have only one exit point, and that should be the last statement in the method 272
A method should have only one exit point, and that should be the last statement in the method 281
A method should have only one exit point, and that should be the last statement in the method 291

org/apache/james/jdkim/tagvalue/TagValue.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 100
Found 'DD'-anomaly for variable 'i' (lines '184'-'140'). 184 - 140
Avoid using final local variables, turn them into fields 190
Found 'DD'-anomaly for variable 'result' (lines '191'-'192'). 191 - 192
A method should have only one exit point, and that should be the last statement in the method 199
A method should have only one exit point, and that should be the last statement in the method 201
A method should have only one exit point, and that should be the last statement in the method 203
A method should have only one exit point, and that should be the last statement in the method 207
A method should have only one exit point, and that should be the last statement in the method 209
A method should have only one exit point, and that should be the last statement in the method 220
Assigning an Object to null is a code smell. Consider refactoring. 226
Found 'DU'-anomaly for variable 'headers' (lines '245'-'260'). 245 - 260
These nested if statements could be combined 252 - 254
Found 'DD'-anomaly for variable 'i' (lines '257'-'246'). 257 - 246
A method should have only one exit point, and that should be the last statement in the method 266